From be519afe5fdd956ac092d7ac01f161541e3db3f8 Mon Sep 17 00:00:00 2001 From: Omar Rizwan Date: Sun, 21 Mar 2021 15:35:01 -0700 Subject: extension,test: Start on simplifying routing. Introduces a 'named variable' syntax so we can remove all the manual indexing into path components / converting to int in individual fs ops. Also rewrites the route finding to use regex: all routes are compiled to regexes, then the route finder just walks through them all until it hits a match. Doesn't fully work yet; JS test passes. --- test/test.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'test') diff --git a/test/test.js b/test/test.js index 1288bf4..6376885 100644 --- a/test/test.js +++ b/test/test.js @@ -6,7 +6,7 @@ global.chrome = {}; const {router, findRoute} = require('../extension/background'); (async () => { - const tabRoute = await router['/tabs/by-id/*'].readdir(); + const tabRoute = await router['/tabs/by-id/#TAB_ID'].readdir(); assert(['.', '..', 'url.txt', 'title.txt', 'text.txt'] .every(file => tabRoute.entries.includes(file))); @@ -16,6 +16,6 @@ const {router, findRoute} = require('../extension/background'); { entries: ['.', '..', 'create', 'by-id', 'by-title', 'last-focused'] }); - assert.deepEqual(findRoute('/tabs/by-id/TABID/url.txt'), - router['/tabs/by-id/*/url.txt']); + assert.deepEqual(findRoute('/tabs/by-id/10/url.txt'), + router['/tabs/by-id/#TAB_ID/url.txt']); })(); -- cgit v1.2.3